Respected Professor,
Thank you for your very good advice. You are completely right with everything: a) EPSG:4326 stored in JSON: Done! Instead of hardcoding them directly in the Python script, the string variables 'EPSG: 4326' are now in the JSON (config) file.
b) Avoid the redundant config_data dictionary: Done! The hardcoded lines were unnecessary and are now removed, since the config_data is also read from the JSON file.
The JSON file is created if it does not yet exist (first start of the software) The configuration is always read from the JSON file The redundant hardcoded dictionary is removed
c) Naming is not matching: Done! The watershed_analysis.py will always create and read the corresponding watershed_analysis.json, leading to a perfectly logical relationship between Python file and JSON config.
This in fact created a clean, professional, and maintainable codebase !!
Thank you for these great tips that have strongly improved the code structure.
- Bhuwan
On Thu, Aug 7, 2025 at 6:11 PM Venkatesh Raghavan via PyGILE < pygile@geoinfo-lab.org> wrote:
Bhuvan,
a) Even variables like 'EPSG:4326' can be defined in the json file
b) are the lines below necessary in yje Python script?
config_data = { "dem_path": "/workspace/Road_Induced_Solu/Solu_Dem/Solu.tif", "temp_dir": "temp_watershed", "output_dir": "results", "watershed_dem": "results/clipped_dem.tif", "conda_env_path": "/opt/conda/envs/pygile", "saga_cmd": "/opt/saga/bin/saga_cmd", "saga_lib": "/opt/saga/lib/saga", "grass_bin": "/opt/grass/grass84/bin", "otb_bin": "/opt/otb/bin", "whitebox_tools": "/opt/conda/envs/pygile/bin/whitebox_tools" }
I think the data is being read from the json file.
c) each python script will read parameters from json file, so it is better if the python file and json file share the same name.
Venka
On 8/7/2025 7:29 PM, Bhuwan Awasthi wrote:
Respected Professor,
As per your instructions, the updated example has been pushed to the
GITHUB
repository of PyGILE-Plus. This looks more convenient to work with. Thank you for pointing it out.
- Bhuwan
On Thu, Aug 7, 2025 at 2:02 PM Venkatesh Raghavan via PyGILE < pygile@geoinfo-lab.org> wrote:
Here's a simple example of json and python script pair.
The python script will read input and output variables from
json file and execute. No need to hardcode (or edit python script)
and you can run the script on different data by editing json file.
Venka _______________________________________________ PyGILE mailing list -- pygile@geoinfo-lab.org To unsubscribe send an email to pygile-leave@geoinfo-lab.org
PyGILE mailing list -- pygile@geoinfo-lab.org To unsubscribe send an email to pygile-leave@geoinfo-lab.org